Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail filters #10135

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

mail filters #10135

wants to merge 7 commits into from
+2,101 −39

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 12, 2024 •
edited by hamza221
Loading

Todo Hamza:

  • Use NcSelect with multiple objects for test value selection (wrapped, unlimited width)
  • Actions: Add label "Delete action"
  • Divider/Whitespace to group tests and actions
  • Delete filter => weird state
  • Save filter => success toast
  • Form validation => Make it a real form
  • Error state
  • MailFilterOperator: Don't modify prop
  • Remove operator true
  • Enable filter by default
  • Change modal title "Name inside modal " to "Update mail filter"
  • Check modal size
  • Input spacing/width

Todo Daniel:

  • Add tests
  • Tests with ooo script
  • Filter definitions
  • To much newlines for the generate script
  • Support for quotes in values
  • Translation for operators
  • Help text

@ChristophWurst ChristophWurst marked this pull request as draft September 12, 2024 09:32
@kesselb kesselb changed the title Mail filters mail filters Sep 12, 2024
@hamza221 hamza221 mentioned this pull request Sep 12, 2024
Merged
hamza221
hamza221 reviewed Sep 16, 2024
View reviewed changes
src/components/MailFilters.vue Outdated
this.loading = false
}

await this.$store.dispatch('fetchActiveSieveScript', { accountId: this.account.id })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the store manually instead of querying backend on each update ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, do I need to return the new script as result for the update operation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it in the other PR

@kesselb @hamza221
feat: mail filters
5bbace0 
Co-authored-by: Hamza Mahjoubi <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb and others added 4 commits September 18, 2024 18:21
@kesselb
fixup! feat: mail filters
bff2010 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fixup! feat: mail filters
c2b728f 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fixup! feat: mail filters
8c964c2 
Signed-off-by: Daniel Kesselberg <[email protected]>
@hamza221
fixup! feat: mail filters
98320f1 
Signed-off-by: Hamza Mahjoubi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 left review comments

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kesselb kesselb

@hamza221 hamza221

Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @hamza221 @ChristophWurst