-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mention to mail #10122
feat: add mention to mail #10122
Conversation
aaa8db2
to
45d8e43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb feature!
Works well! I only noticed a few minor issues
- There are XHR requests to search for empty names
- There is an XHR request to search once the mention suggestion is selected with tab/enter
Nice to have
- Avoid searching the same term again. Cache the responses.
Unfortunately that can't / will be hard to fix since that's how the mention plugin work in CKEditor (a feature not a bug) |
Fair, but we can just not do a request for an empty string ;-) |
yes that's fixed |
69770e0
to
d57f98f
Compare
Signed-off-by: Hamza Mahjoubi <[email protected]>
fix #10110
Screen.Recording.2024-09-19.at.15.23.34.mov