test: fix redis not being used properly in imapClientFactoryTest #10076
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
force-pushed
the
fix/imap/persist-deleted-messages
branch
from
44c5315
to
06fa8a8
Compare
st3iny
force-pushed
the
test/redis-not-used
branch
from
e48e41b
to
f4e1536
Compare
st3iny
force-pushed
the
fix/imap/persist-deleted-messages
branch
from
67a12d7
to
c7dff93
Compare
st3iny
force-pushed
the
fix/imap/persist-deleted-messages
branch
from
33cc44d
to
3b577fe
Compare
st3iny
changed the base branch from
fix/imap/persist-deleted-messages
to
main
st3iny
force-pushed
the
test/redis-not-used
branch
from
4117cb5
to
ef3350e
Compare
st3iny
force-pushed
the
test/redis-not-used
branch
from
ef3350e
to
390838e
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
test/redis-not-used
branch
from
390838e
to
d9c84f9
Compare
st3iny
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
kesselb
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while developing #10036.
The injected cache factory from OCP will always inject an
ArrayCacheinstance whenPHPUNIT_RUNis defined.https://github.com/nextcloud/server/blob/606241caebda2e01702c0d08adbc35ace8d01f13/lib/private/Server.php#L600-L638
Force to use the configured cache and also assert that it is an instance of Redis in the affected test.