Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envelope: temporarily disable oneline mode on small screen sizes #10072

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Envelope: temporarily disable oneline mode on small screen sizes #10072

merged 1 commit into from
Sep 2, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #9753

@GVodyanov GVodyanov self-assigned this Aug 29, 2024
@GretaD GretaD force-pushed the style/disable-oneline-on-mobile branch from 8f31844 to 1d5cefa Compare September 2, 2024 09:49
@GretaD GretaD requested a review from kesselb as a code owner September 2, 2024 09:49
@GretaD
Copy link
Contributor

GretaD commented Sep 2, 2024

fixed this one, my ocd couldnt allow this to get merged without it :)

Screenshot from 2024-09-02 11-52-11

GretaD
GretaD approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works

@GretaD
Copy link
Contributor

GretaD commented Sep 2, 2024 •
edited
Loading

run npm lint:fix to fix the lint issue

@GVodyanov GVodyanov force-pushed the style/disable-oneline-on-mobile branch from 1d5cefa to 5ae5fc0 Compare September 2, 2024 14:47
@GVodyanov GVodyanov enabled auto-merge (squash) September 2, 2024 14:47
@GVodyanov GVodyanov merged commit cba9bed into main Sep 2, 2024
27 of 28 checks passed
@GVodyanov GVodyanov deleted the style/disable-oneline-on-mobile branch September 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

@GVodyanov GVodyanov

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In "list layout", add a breakpoint and switch back to the 3 line element when the screen becomes too narrow
2 participants
@GVodyanov @GretaD