Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: cross link app settings to account settings #10049

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 26, 2024

fixes #9161
Please notice that the mockup on the ticket is on the wrong modal :)
To do

  • Add the account settings option to app settings modal
  • Close the app settings modal when the account settings modal is opened

Screenshot from 2024-09-04 14-34-09

@GretaD GretaD self-assigned this Aug 26, 2024
@GretaD GretaD force-pushed the enhanc/cross-link-appsettings branch from c0d8f44 to 4c89b26 Compare September 4, 2024 12:31
@GretaD GretaD marked this pull request as ready for review September 4, 2024 12:34
@GretaD
Copy link
Contributor Author

GretaD commented Sep 4, 2024

@kesselb your suggestion worked, yaaay :)

@GretaD GretaD requested a review from hamza221 September 5, 2024 07:56
@GVodyanov
Copy link
Contributor

The only thing I could complain about is the margin-bottom: 80px for the settings section being a little exaggerated, but that's a nextcloud vue thing, I guess if designers will want it will be changed eventually

@kesselb
Copy link
Contributor

kesselb commented Sep 5, 2024

I find "Settings for:" a bit redundant.

@GretaD GretaD force-pushed the enhanc/cross-link-appsettings branch from 8cd8648 to cb67528 Compare September 5, 2024 17:33
@GretaD GretaD merged commit ae12c7b into main Sep 5, 2024
32 checks passed
@GretaD GretaD deleted the enhanc/cross-link-appsettings branch September 5, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross link app settings to account settings for discoverability
3 participants