Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new share type #29

Open
schiessle opened this issue Jun 11, 2022 · 6 comments
Open

Introducing new share type #29

schiessle opened this issue Jun 11, 2022 · 6 comments

Comments

@schiessle
Copy link
Member

We are in the process of developing federated group sharing in a way that for example in a Global Scale setup every member of a group gets access to the share, no matter on which Nextcloud server the user is located.

If you are interested you can find all the documents and the detailed description here: https://cloud.nextcloud.com/index.php/f/6222227

Therefore we need the clients to know the new share type and handle it properly:

  1. When typing a name in the share dialog this "federated groups" will come back as part of the result. We should show this groups with a special icon in the share dialog to distinguish them from local groups?
  2. Once shared the user should be able to distinguish between a local group share and a federated group share in the list of shares. Also here this new share type should get it's own icon.

The main developer on the server side will be @smesterheide supported by @come-nc

cc @tobiasKaminsky for your reference, as discussed

@tobiasKaminsky
Copy link
Member

@nextcloud/designers shall we use group icon for this? This is already used for groupfolders:
image

@tobiasKaminsky
Copy link
Member

image

For searching it would then be
"group"
"on xyz.server.com" ?

@smesterheide
Copy link

Hey all, it might be helpful to distinguish between the federated group share in a general sense and the implementation of said share type as a Virtual Organisation (VO) group share I am currently working on. Can we treat this as one and the same @schiessle?

The VO groups are managed outside of Nextcloud and users might already be familiar with existing icons in this context. I will check and report back on that.

Thanks for the suggestions @tobiasKaminsky! I like the regular group icon as shown for "group". Maybe we can use a variation of that to highlight that we are dealing with a special type of group.

@tobiasKaminsky
Copy link
Member

Thanks for the suggestions @tobiasKaminsky! I like the regular group icon as shown for "group". Maybe we can use a variation of that to highlight that we are dealing with a special type of group.

@nextcloud/designers as also Björn mentioned in first post, federated group shares should have a different icon.
Do you have an idea? :)

@jancborchardt
Copy link
Member

jancborchardt commented Jun 14, 2022

The icon can/should be the same as the group icon you mentioned @tobiasKaminsky. That it’s a federated share is communicated in the sidebar, nothing we need to press into the icon. :)

@tobiasKaminsky
Copy link
Member

@schiessle @smesterheide once you have a PR on server ready to test, I am happy to give it a try on Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

4 participants