Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new API to allow user to upload an existing certificate #669

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mgallien
Copy link
Contributor

is needed to be able to setup sharing when an user has an existing certificate that may have been created outside of Nextcloud end-to-end encryption app

that would for example apply when an external certificate authority is in use to deliver user certificates for end-to-end encryption

@mgallien mgallien requested a review from artonge June 26, 2024 09:36
lib/Controller/KeyController.php Outdated Show resolved Hide resolved
/**
* Set public key
*
* @NoAdminRequired
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements are really that a user should be able to set its own public key? And not that an admin should be able to set a user's public key?

Copy link
Contributor Author

@mgallien mgallien Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be done by users as there may be situations where the user's certificate is issued by a different component from the Nextcloud server app and the user should be able to upload their certificate to enable end-to-end encrypted share feature
I would guess that we want logged-in users to be able to do it as if they were uploading just a certificate signing request (this workflow works without administrator doing something)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess that we want logged-in users to be able to do it as if they were uploading just a certificate signing request (this workflow works without administrator doing something)

Please make sure of it. If this is true, then it looks ok :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if that is unclear
yes, normal users need to be able to upload their certificate to enable sharing
now that you ask for, I think we should ensure the user certificate is valid before storing it

@mgallien mgallien force-pushed the mgallien/feat/addUploadOfUserCertificate branch from bc27db8 to 3305eca Compare June 28, 2024 12:01
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews enhancement New feature or request labels Jun 28, 2024
@mgallien mgallien requested a review from artonge July 1, 2024 14:28
@mgallien mgallien force-pushed the mgallien/feat/addUploadOfUserCertificate branch from 3305eca to b9a70c8 Compare July 31, 2024 11:42
is needed to be able to setup sharing when an user has an existing
certificate that may have been created outside of Nextcloud end-to-end
encryption app

that would for example apply when an external certificate authority is
in use to deliver user certificates for end-to-end encryption

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the mgallien/feat/addUploadOfUserCertificate branch from b9a70c8 to 27cfa29 Compare August 13, 2024 13:37
@mgallien mgallien merged commit 2da943c into master Aug 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants