Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (or warn) when E2EE is enabled at the same time as SSE #533

Closed
joshtrichards opened this issue Dec 26, 2023 · 5 comments
Closed
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@joshtrichards
Copy link
Member

Since they're incompatible currently.

Unfortunately as far as I can tell there's no way to specify in the appinfo/info.xml for this and the encryption app a way to prevent them from being enabled in parallel. In addition, since most interaction occurs client-side, simply returning 4xx codes won't necessarily give the appropriate visibility to any error/warning message when attempting to perform encryption related options.

Some ideas:

  • Add a setup check under Admin Overview
  • Add a post installation check that causes all E2EE client requested operations to basically be blocked (not friendly but at least keeps things from getting screwed up to start with)
  • Add functionality to apps store/app metadata to support specifying apps that aren't compatible with each other
  • Add a check in both this app and the encryption app that warns during any UI or CLI settings operations/interactions that the other app was detected and that the user has an invalid deployment/configuration
  • ?
@joshtrichards joshtrichards added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Dec 26, 2023
@sorbaugh
Copy link

sorbaugh commented Feb 2, 2024

Many good ideas here that each have merit on their own and since many people seems to running into this "trap", maybe we can at least start with adding a WARNING text. What do you think @artonge ?

PS: The long term solution will be to make both SSE and E2EE compatible with each other.

@karlemilnikka
Copy link

According to the Nextcloud 30 (Nextcloud Hub 9) presentation video, E2EE shall now be possible to use in conjunction with SSE. Please note that the E2EE app hasn’t been updated for Nextcloud 30 yet.

@artonge
Copy link
Collaborator

artonge commented Sep 16, 2024

I just released a version for 30

@artonge artonge closed this as completed Sep 16, 2024
@artonge
Copy link
Collaborator

artonge commented Sep 16, 2024

My bad, there was an error in the release

@artonge
Copy link
Collaborator

artonge commented Sep 16, 2024

Done 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants