Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dev): new arguments for BeforePreviewFetchedEvent #10674

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 26, 2023

☑️ Resolves

🖼️ Screenshots

Screenshot from 2023-06-26 13-52-21


Deprecated APIs
^^^^^^^^^^^^^^^

* tbd
* ``\OCP\Preview\BeforePreviewFetchedEvent`` passing ``null`` for ``width, height, crop or mode`` is deprecated. Starting with Nextcloud 31 they are mandatory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was 3 years and not 3 major releases, right? 🤣

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

@ChristophWurst ChristophWurst merged commit e5744dc into master Jun 26, 2023
@ChristophWurst ChristophWurst deleted the docs/event-preview branch June 26, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants