Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dark mode regressions on Windows 10 #7463

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Revert dark mode regressions on Windows 10 #7463

wants to merge 11 commits into from
+131 −50

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Nov 5, 2024 •
edited
Loading

Closes #7269

@claucambra claucambra added os: 🚪 Windows hotspot: visual Window positioning, font sizing, etc. labels Nov 5, 2024
@claucambra claucambra self-assigned this Nov 5, 2024
@claucambra claucambra force-pushed the bugfix/revert-windows-dark-regressions branch 3 times, most recently from 06d2cca to a7e2afd Compare November 5, 2024 08:28
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra added this to the 3.14.5 milestone Nov 5, 2024
@claucambra claucambra force-pushed the bugfix/revert-windows-dark-regressions branch from a7e2afd to dbf4d1d Compare November 5, 2024 08:49
mgallien
mgallien requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not work
still getting this
image
settings dialog stays light mode
image

mgallien
mgallien reviewed Nov 8, 2024
View reviewed changes
src/libsync/theme.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/revert-windows-dark-regressions branch from d3cf8e6 to f913087 Compare November 10, 2024 13:40
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@mgallien mgallien force-pushed the bugfix/revert-windows-dark-regressions branch from f913087 to 579109d Compare November 12, 2024 13:17
stertingen
stertingen reviewed Nov 12, 2024
View reviewed changes
src/gui/main.cpp Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/revert-windows-dark-regressions branch from a7f00e2 to 73533f1 Compare November 12, 2024 14:34
@mgallien
use QWidget Fusion style on Windows 10: enable dark mode
5b2ca2c 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
create a log category for OCC::Theme class
24308c3 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
implement a drak mode palette and use it when needed
8fedc7c 
for now unable to dynamically switch between light and dark mode

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
on Windows 10 follow color scheme changes and apply them
4711f1f 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/revert-windows-dark-regressions branch from 151db0d to 29c57e6 Compare November 13, 2024 14:35
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7463-29c57e6a6555eedfd8db2fcaf41307c36f223e7f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.1% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)
24 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stertingen stertingen stertingen left review comments

@mgallien mgallien mgallien requested changes

@camilasan camilasan Awaiting requested review from camilasan

Requested changes must be addressed to merge this pull request.

Assignees

@claucambra claucambra

Labels
backport-request hotspot: visual Window positioning, font sizing, etc. os: 🚪 Windows
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud UI (3.14.1) is broken on Windows 10 (21H2 19044.4894) using dark mode
5 participants
@claucambra @nextcloud-desktop-bot @mgallien @stertingen @Rello