Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding account and skipping folder configuration crash. #7436

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix adding account and skipping folder configuration crash. #7436

wants to merge 12 commits into from
+142 −142

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Oct 30, 2024 •
edited
Loading

  • when adding account on mac OS and skipping the folder configuration step, it would crash and it would add an empty user as an account.
  • the dialog for configuring folder it was never going away once the user would click on skip.

@camilasan camilasan force-pushed the bugfix/accounts2 branch 2 times, most recently from 24235b5 to afc2afc Compare November 4, 2024 20:13
@camilasan camilasan changed the title WIP: Bugfix/accounts2 Fix adding account and skipping folder configuration crash. Nov 5, 2024
@camilasan camilasan marked this pull request as ready for review November 5, 2024 09:41
@camilasan
Copy link
Member Author

/backport to stable-3.14

@camilasan camilasan added this to the 3.14.5 milestone Nov 5, 2024
@camilasan
Use slotComputeOverallSyncStatus as a slot.
0b520b0 
- Use qAsConst.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Fix warning "Calling C++ methods with 'this' objects different from t…
190ae09 
…he one they were retrieved from is broken"

https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Modernize Account::displayName().
b8b99d0 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use slots as slots.
c7e7dda 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Diferentiate between display name and dav display name.
f81e999 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Rename vars: _am => _networkAccessManager, a => newAccountData.
b101f3b 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use saveAccount for adding single account.
d759b13 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add {} to single line if.
2a0d46d 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
acc => account.
be82a67 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
wiz => owncloudSetupWizard.
d8e9ffe 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Call for done() when skipping folder configuration.
f3600c9 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove check before setting display name.
0e78d71 
Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7436-0e78d71446e8c7b812cbbde053c700b03e5905a3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra Awaiting requested review from claucambra

@mgallien mgallien Awaiting requested review from mgallien

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @Rello