Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] Only check for leading/trailing space for files on Windows. #7225

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 27, 2024

Backport of #6871

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

…rtingOs.

- Fix discovery tests for files with invalid names.
- Now leading/trailing spaces trigger an error only on Windows.

Signed-off-by: Camila Ayres <[email protected]>
@backportbot backportbot bot added 3. to review hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. labels Sep 27, 2024
@backportbot backportbot bot added this to the 3.13.5 milestone Sep 27, 2024
@mgallien mgallien marked this pull request as ready for review October 2, 2024 12:17
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7225-fe373a5ed105b16607b974ca95c32b4cd5e52042-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit d809304 into stable-3.13 Oct 2, 2024
11 of 14 checks passed
@mgallien mgallien deleted the backport/6871/stable-3.13 branch October 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review hotspot: filename handling Filenames - invalid, portable, blacklisting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants