ensure detection of entry type on windows is reliable #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
reviewed
Sep 3, 2024
camilasan
reviewed
Sep 3, 2024
it seems that there is a possibility for the type detection to report a folder as being a file with this change, I am pretty sure that cannot happen any longer Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/ensureReliableFileFolderDetection
branch
from
348f31e
to
fcc325f
Compare
|
AppImage file: nextcloud-PR-7068-fcc325ffbb47362cdfbb5dd2057cffe9c06030fb-x86_64.AppImage |
|
camilasan
approved these changes
Sep 5, 2024
|
/backport to stable-3.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems that there is a possibility for the type detection to report a folder as being a file
with this change, I am pretty sure that cannot happen any longer