[stable-3.13] Improve the syncing status text displayed to the user #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
camilasan
force-pushed
the
backport/6882/stable-3.13
branch
from
14ea7cd
to
f224e5e
Compare
- Add margin to sync progress text. - Make use of the text in FolderStatusDelegate::FolderSyncText. Signed-off-by: Camila Ayres <[email protected]>
- Add const auto. - Change variable names to be more clear. Signed-off-by: Camila Ayres <[email protected]>
- Never display "please wait" to users. - Only start displaying status starting at 1. e.g. "0 f 6 files" => "1 of 6 files" - Improve text for FolderStatusDelegate::FolderSyncText. - Reconciling => Syncing. - Syncing => Sync. Signed-off-by: Camila Ayres <[email protected]>
…ing. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
backport/6882/stable-3.13
branch
from
f224e5e
to
81c070e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6882
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.