Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the syncing status text displayed to the user #6882

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Improve the syncing status text displayed to the user #6882

merged 5 commits into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. Display more details of the sync progress in the settings dialog. 

    - Add margin to sync progress text.
- Make use of the text in FolderStatusDelegate::FolderSyncText.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan
    camilasan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b5888f4 View commit details
    Browse the repository at this point in the history

  2. Modernize FolderStatusModel::slotSetProgress. 

    - Add const auto.
- Change variable names to be more clear.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan
    camilasan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    23a1770 View commit details
    Browse the repository at this point in the history

  3. Make sync status text easier to understand. 

    - Never display "please wait" to users.
- Only start displaying status starting at 1. e.g. "0 f 6 files" => "1 of 6 files"
- Improve text for FolderStatusDelegate::FolderSyncText.
- Reconciling => Syncing.
- Syncing => Sync.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan
    camilasan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0f2554e View commit details
    Browse the repository at this point in the history

  4. Capitalize sync instruction strings returned by Progress::asActionStr… 

    …ing.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan
    camilasan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5cf4e87 View commit details
    Browse the repository at this point in the history

  5. List less file names in the sync progress bar text. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan
    camilasan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    43777be View commit details
    Browse the repository at this point in the history