Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(clang-tidy-review): Fix for qt6 + swap to docker-ci container #6860

Merged
merged 8 commits into from
Jul 21, 2024
Merged

ci(clang-tidy-review): Fix for qt6 + swap to docker-ci container #6860

merged 8 commits into from
Jul 21, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 29, 2024 •
edited
Loading

  • Fix cmake command line for qt6 (as already has been done for other CI tests)
  • Switch to the ci-client-qt6 image for consistency with other tests and to eliminate package install step

Let's see how the CI run likes it in the first pass...

@joshtrichards joshtrichards added bug CI continuous integration, Drone, testing 2. developing labels Jun 29, 2024
@joshtrichards joshtrichards marked this pull request as ready for review June 29, 2024 21:17
claucambra
claucambra approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@claucambra claucambra force-pushed the jtr/fix-ci-clang-tidy-review-qt6 branch from 7b5e0ac to 5c3c6a8 Compare July 21, 2024 06:18
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6860-5c3c6a81405df2ab2fc14c2273905734f0d1b8cb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@claucambra claucambra merged commit c19bf79 into master Jul 21, 2024
14 of 15 checks passed
@claucambra claucambra deleted the jtr/fix-ci-clang-tidy-review-qt6 branch July 21, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

Assignees
No one assigned
Labels
3. to review bug CI continuous integration, Drone, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshtrichards @nextcloud-desktop-bot @claucambra