Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfapi logging #6826

Draft
wants to merge 6 commits into
base: stable-3.12
Choose a base branch
from
Draft

cfapi logging #6826

wants to merge 6 commits into from
+124 −9

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Jun 19, 2024 •
edited
Loading

camilasan and others added 6 commits June 17, 2024 15:57
@camilasan
Show details of the syncing progress in the settings dialog.
49af4fe 
Before it was only shown in the tooltip.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add logs.
21efcd9 
Signed-off-by: Camila Ayres <[email protected]>
@mgallien @camilasan
only compute checksum of a local file that is not a virtual one
95d43fc 
should avoid triggering implicit hydration from within the desktop
client

triggering an implicit hydration on our own is strictly forbidden as
that is causing issues like deadlock and failed hydration attempts

Signed-off-by: Matthieu Gallien <[email protected]>
@camilasan
Add logs.
f11a9df 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add new cfapi callbacks for logging.
57b3619 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Print desktop client process id.
b03c105 
Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6826-b03c105abf0165fcef37663a4e9a058afbb4bd93-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.3% Coverage on New Code (required ≥ 80%)
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @mgallien