-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "The host name did not match any of the valid hosts for this certificate" notification even when the certificate was valid #6785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my inline comments
1f47254
to
2f57d7e
Compare
2f57d7e
to
b8a5954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build is broken
can you make sure CI is green ?
e23f2cd
to
592ef1c
Compare
…nections. One option is said to be possibly breaking some sites: QSsl::SslOptionDisableSessionTickets It disables the SSL session ticket extension and some servers are not compatible with the extension. Signed-off-by: Camila Ayres <[email protected]>
…s are allowed. Signed-off-by: Camila Ayres <[email protected]>
- Those settings were removed. - Modernize CheckServerJob::finished. Signed-off-by: Camila Ayres <[email protected]>
We have set QNetworkRequest::RedirectPolicyAttribute to QNetworkRequest::NoLessSafeRedirectPolicy: the Network Access API should automatically follow a HTTP redirect response. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
592ef1c
to
f1e3901
Compare
AppImage file: nextcloud-PR-6785-f1e3901ea324f7cc4fd95de4dad0df1f9ff5a3f5-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
"The host name did not match any of the valid hosts for this certificate"