Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix incorrect date parsing." #6748

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Revert "Fix incorrect date parsing." #6748

merged 1 commit into from
Sep 5, 2024

Conversation

allexzander
Copy link
Contributor

This reverts commit 04c0125.

@allexzander
Copy link
Contributor Author

this commit should not go with PR #6742, so reverting it

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien force-pushed the fix/revert-date-parsing-fix branch 2 times, most recently from 0620e3b to 6098039 Compare August 13, 2024 07:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@allexzander @mgallien
Revert "Fix incorrect date parsing."
de18970 
This reverts commit 04c0125.

Signed-off-by: alex-z <[email protected]>
@mgallien mgallien merged commit 5f1256c into master Sep 5, 2024
10 of 14 checks passed
@mgallien mgallien deleted the fix/revert-date-parsing-fix branch September 5, 2024 17:01
@mgallien
Copy link
Collaborator

mgallien commented Sep 5, 2024

/backport to stable-3.14

@backportbot backportbot bot mentioned this pull request Sep 5, 2024
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6748-de18970443507ed4260e595d5fbd44c89a7ff732-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allexzander @mgallien @nextcloud-desktop-bot