Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-appimage.sh to use $VERSION_SUFFIX #6714

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

camilasan
Copy link
Member

Make sure that we can pass the value of MIRALL_VERSION_SUFFIX via parameter.

fixes #6631

@camilasan camilasan requested a review from mgallien April 29, 2024 19:13
@camilasan
Copy link
Member Author

/backport to stable-3.13

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Make sure that we can pass the value of MIRALL_VERSION_SUFFIX via parameter.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan merged commit 3b51aa2 into master Jun 4, 2024
10 of 12 checks passed
@camilasan camilasan deleted the bugifx/version-suffix branch June 4, 2024 21:00
Copy link

backportbot bot commented Jun 4, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6714/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d07f1315

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6714/stable-3.13

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

1 similar comment
Copy link

backportbot bot commented Jun 4, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6714/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d07f1315

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6714/stable-3.13

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6714-d07f1315764350ce97341f42ba8d727787fba639-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mgallien added a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: New version dialog: version number/name and availability of it
4 participants