Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent use of invalid characters for file provider domain names #6669

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Apr 23, 2024

Closes #6661

@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@camilasan camilasan force-pushed the bugfix/invalid-chars-fp-domains branch from c8347a6 to 6c13e9b Compare April 23, 2024 16:48
@camilasan camilasan enabled auto-merge (rebase) April 23, 2024 16:48
@camilasan camilasan disabled auto-merge April 23, 2024 17:10
@camilasan camilasan force-pushed the bugfix/invalid-chars-fp-domains branch from 6c13e9b to 10faa00 Compare April 23, 2024 17:11
@camilasan camilasan merged commit 591d5ee into master Apr 23, 2024
9 of 12 checks passed
@camilasan camilasan deleted the bugfix/invalid-chars-fp-domains branch April 23, 2024 17:11
Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6669/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 10faa006

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6669/stable-3.13

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6669-10faa006e7399c9bfeb80a441c85a7962d7e8af6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File Provider domain identifiers cannot be created containing slashes or colons
3 participants