Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create registry keys needed for edit locally in local machine category #6663

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Apr 23, 2024

creating the registry keys via installer for the current user is not enough to have the feature enabled for all user accounts on a given machine

@mgallien mgallien force-pushed the bugfix/editLocallyShouldWorkForAllMachineUsers branch from 93113dd to bbae698 Compare April 23, 2024 08:19
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien mgallien force-pushed the bugfix/editLocallyShouldWorkForAllMachineUsers branch from bbae698 to 4a99026 Compare April 23, 2024 10:29
creating the registry keys via installer for the current user is not
enough to have the feature enabled for all user accounts on a given
machine

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/editLocallyShouldWorkForAllMachineUsers branch from 4a99026 to 06c2fec Compare April 23, 2024 11:48
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6663-06c2fecbe12fbb819140590e25422f18d70266aa-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien merged commit c0af76c into master Apr 23, 2024
11 of 13 checks passed
@mgallien mgallien deleted the bugfix/editLocallyShouldWorkForAllMachineUsers branch April 23, 2024 12:49
Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6663/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 06c2fecb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6663/stable-3.12

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
src/gui/macOS/ClientCommunicationProtocol.h
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mgallien
Copy link
Collaborator Author

git push origin backport/6663/stable-3.12

#6672

@mgallien mgallien added this to the 3.14.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants