Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/folder conflict disappear #6655

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander marked this pull request as ready for review April 21, 2024 21:48
@allexzander allexzander force-pushed the bugfix/folder-conflict-disappear branch 2 times, most recently from dc38e80 to d26b253 Compare April 22, 2024 20:35
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

src/libsync/propagatorjobs.cpp Show resolved Hide resolved
@allexzander
Copy link
Contributor Author

/backport to stable-3.13

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

…d if it contains conflicted subfolers. Also fix crash with local rename.

Signed-off-by: alex-z <[email protected]>
…cord if it contains conflicted subfolders.

Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the bugfix/folder-conflict-disappear branch from d26b253 to b52906a Compare April 23, 2024 10:18
@allexzander allexzander merged commit f40b8ae into master Apr 23, 2024
9 of 12 checks passed
@allexzander allexzander deleted the bugfix/folder-conflict-disappear branch April 23, 2024 10:18
Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6655/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d240ed9d d2bfb59d 57f6c7cd 9ae60258 f490989a b52906a8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6655/stable-3.12

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
src/gui/macOS/ClientCommunicationProtocol.h
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6655-b52906a8a6ddc8f30547ca2e5a544c2c5d2625bd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants