Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows .lnk files with VFS Cf API. #6629

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Support Windows .lnk files with VFS Cf API. #6629

merged 3 commits into from
Jul 11, 2024

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander force-pushed the feature/support-lnk-files-in-vfs-win branch 6 times, most recently from 048a41c to d7bd041 Compare April 15, 2024 04:49
@allexzander allexzander marked this pull request as ready for review April 24, 2024 10:45
@allexzander allexzander force-pushed the feature/support-lnk-files-in-vfs-win branch from 130c4db to 153d82e Compare April 24, 2024 18:28
mgallien
mgallien requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and resolve conflicts

@allexzander allexzander force-pushed the feature/support-lnk-files-in-vfs-win branch from 153d82e to 3b7e958 Compare May 7, 2024 17:55
@allexzander allexzander requested a review from mgallien May 7, 2024 20:27
@allexzander
Copy link
Contributor Author

please rebase and resolve conflicts

Done.

@allexzander allexzander force-pushed the feature/support-lnk-files-in-vfs-win branch from 3b7e958 to e8f162a Compare May 13, 2024 15:52
@mgallien mgallien force-pushed the feature/support-lnk-files-in-vfs-win branch from e8f162a to a5a1f61 Compare May 29, 2024 13:34
@mgallien mgallien force-pushed the feature/support-lnk-files-in-vfs-win branch from a5a1f61 to 2315aeb Compare June 11, 2024 09:12
@mgallien mgallien force-pushed the feature/support-lnk-files-in-vfs-win branch 2 times, most recently from a664c9c to cd5afa7 Compare June 28, 2024 09:08
@mgallien mgallien force-pushed the feature/support-lnk-files-in-vfs-win branch from cd5afa7 to 28d69e9 Compare July 10, 2024 08:29
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6629-28d69e9e2c7157f1b18884b0de819c0061ec6178-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
71.3% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
145 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit bc98a6d into master Jul 11, 2024
11 of 14 checks passed
@mgallien mgallien deleted the feature/support-lnk-files-in-vfs-win branch July 11, 2024 13:41
@tobiasKaminsky tobiasKaminsky mentioned this pull request Jul 15, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allexzander @nextcloud-desktop-bot @mgallien