Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with KF6 #6599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build with KF6 #6599

wants to merge 2 commits into from
+6 −1

Conversation

nicolasfella
Copy link
Contributor

Set QT_NO_CREATE_VERSIONLESS_FUNCTIONS, otherwise Qt5 and Qt6 conflict

@nicolasfella
Fix build with KF6
b2974a5 
Set QT_NO_CREATE_VERSIONLESS_FUNCTIONS, otherwise Qt5 and Qt6 conflict

Signed-off-by: Nicolas Fella <[email protected]>
@Flowdalic
Copy link
Contributor

FWIW, a user reported in https://bugs.gentoo.org/930943#c7 that this fixes the Gentoo build if both Qt 5 and 6 are installed. So this seems to address a real issue that will happen more often once Qt 6 become more common.

claucambra
claucambra reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need a qt6_add_resources?

@mgallien
Copy link
Collaborator

@nicolasfella could you have a try at resolving the conflicts ?
I am trying to really make sure that the CI checks run via github actions are reliable and always green (so except drone and sonarcloud)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasfella @Flowdalic @mgallien @claucambra