Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on creating debug archive in read-only location #6598

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

claucambra
Copy link
Collaborator

Also notifies user if the location is not writeable, and sets the documents folder as the default location to stop the user from running into this issue easily

@claucambra
Copy link
Collaborator Author

/backport to stable-3.12

@claucambra
Copy link
Collaborator Author

/backport to stable-3.13.0

@claucambra claucambra added this to the 3.13.0 milestone Apr 17, 2024
@camilasan camilasan enabled auto-merge (rebase) April 23, 2024 16:48
@camilasan camilasan disabled auto-merge April 23, 2024 17:15
@camilasan camilasan merged commit ef08c5e into master Apr 23, 2024
9 of 12 checks passed
@camilasan camilasan deleted the bugfix/debug-archive-crash branch April 23, 2024 17:16
Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.13.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13.0
git pull origin stable-3.13.0

# Create the new backport branch
git checkout -b backport/6598/stable-3.13.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f0e8d16 766ebbf6 30867ca3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6598/stable-3.13.0

Error: Failed to clone repository: Failed to checkout branches: error: pathspec 'stable-3.13.0' did not match any file(s) known to git


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6598/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f0e8d16 766ebbf6 30867ca3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6598/stable-3.12

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
src/gui/macOS/ClientCommunicationProtocol.h
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6598-30867ca3324e86a9d41130e260177c926636e3a3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Apr 23, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants