Fix tests #6596
Merged
Fix tests #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
requested review from
camilasan,
allexzander,
claucambra and
mgallien
claucambra
reviewed
Mar 30, 2024
LocalHost is enough to complete the tests, and it enables the test to be run under networksandboxing. Signed-off-by: Thomas Witt <[email protected]>
Using the real account state needs an internet connection. Additionally, `example.de` is a valid existing domain, which should probably not be used in testing. Switching to `example.com` as this is recommended here. Signed-off-by: Thomas Witt <[email protected]>
This test fails on the day before a timezone switch:
Actual (model.clearAtDisplayString()): "23 hours"
Expected (tr("1 day")) : "1 day"
Setting the timezone to UTC remedies this problem.
Signed-off-by: Thomas Witt <[email protected]>
mgallien
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two changes allow to run tests within a network sandbox, the third fixes a time zone DST change issue