Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite communication between client and File Provider extensions using XPC #6324

Merged
merged 52 commits into from
Feb 19, 2024

Conversation

claucambra
Copy link
Collaborator

Makes communicating with the extensions far more ergonomic and is a requirement for #5693

Closes #6235

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra can you fix the conflicts ?

@claucambra
Copy link
Collaborator Author

Conflicts now fixed

Copy link
Collaborator Author

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-reviewed this and it looks good to me @mgallien

Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…g the same details again

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra merged commit 8ab52b8 into master Feb 19, 2024
9 of 12 checks passed
@claucambra claucambra deleted the work/fileprovider-xpc branch February 19, 2024 14:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6324-3334b4e49c3d4392cfdc9f510bd31eb59018fd22-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace socket-based Client->File Provider Extension communication with in-built File Provider XPC
3 participants