Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a cmake flag to not build with Qt5 WebEngine #6257

Merged
merged 1 commit into from
Dec 5, 2023
Merged

add a cmake flag to not build with Qt5 WebEngine #6257

merged 1 commit into from
Dec 5, 2023

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Dec 4, 2023

No description provided.

@mickenordin
Copy link
Contributor

I tried the patch and it works AND it is very useful :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6257-68763fa5775552dfec1dfe52a01ec7479253222e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 56f043f into master Dec 5, 2023
10 of 12 checks passed
@mgallien mgallien deleted the ci/buildWithoutQt5WebEngine branch December 5, 2023 07:50
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @mickenordin @nextcloud-desktop-bot @claucambra