Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.10] Fix chunk v2 destination header #6141

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[stable-3.10] Fix chunk v2 destination header #6141

merged 4 commits into from
Oct 16, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #6133

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.10.1 milestone Oct 16, 2023
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6141-2b965011838b5bf4269511a54aac2dee04cd6d87-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6141 (2b96501) into stable-3.10 (9dc107d) will increase coverage by 0.00%.
Report is 1 commits behind head on stable-3.10.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           stable-3.10    #6141   +/-   ##
============================================
  Coverage        60.45%   60.46%           
============================================
  Files              145      145           
  Lines            18798    18807    +9     
============================================
+ Hits             11365    11372    +7     
- Misses            7433     7435    +2
Files Coverage Δ
src/common/utility.cpp 74.53% <100.00%> (+0.23%) ⬆️
src/common/utility.h 0.00% <ø> (ø)
src/libsync/propagateupload.h 30.35% <ø> (ø)
src/libsync/propagateuploadng.cpp 85.05% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit a21e89d into stable-3.10 Oct 16, 2023
13 checks passed
@mgallien mgallien deleted the backport/6133/stable-3.10 branch October 16, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-desktop-bot @claucambra @mgallien