Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seen Talk notificatios from Tray window. #5851

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Remove seen Talk notificatios from Tray window. #5851

merged 1 commit into from
Jul 6, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander linked an issue Jun 30, 2023 that may be closed by this pull request
[Bug]: Purge activity entries of chat messages #5682
Closed
8 tasks
@allexzander allexzander force-pushed the feature/remove-seen-talk-notifications branch from d2324fb to 67f89bc Compare June 30, 2023 10:07
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #5851 (e085eea) into master (88b4c7e) will not change coverage.
The diff coverage is n/a.

❗ Current head e085eea differs from pull request most recent head b56200e. Consider uploading reports for the commit b56200e to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5851   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files         145      145           
  Lines       18715    18715           
=======================================
  Hits        11244    11244           
  Misses       7471     7471

claucambra
claucambra approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small optional comment

src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the feature/remove-seen-talk-notifications branch from 67f89bc to 938ee85 Compare July 5, 2023 15:01
@mgallien mgallien enabled auto-merge July 5, 2023 15:01
@allexzander allexzander disabled auto-merge July 5, 2023 16:57
@allexzander allexzander force-pushed the feature/remove-seen-talk-notifications branch from 938ee85 to 540e6f5 Compare July 5, 2023 16:59
@allexzander
Copy link
Contributor Author

/backport to stable-3.9

@allexzander allexzander force-pushed the feature/remove-seen-talk-notifications branch from 540e6f5 to e085eea Compare July 5, 2023 17:52
@allexzander allexzander force-pushed the feature/remove-seen-talk-notifications branch from e085eea to b56200e Compare July 6, 2023 07:15
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5851-b56200e0d7b8812d1680efb85ae78888cef211cb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@allexzander allexzander merged commit 4cc1395 into master Jul 6, 2023
9 of 10 checks passed
@allexzander allexzander deleted the feature/remove-seen-talk-notifications branch July 6, 2023 08:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 6, 2023
Merged
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
@AndyXheli AndyXheli mentioned this pull request Jan 31, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Purge activity entries of chat messages
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien