Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #5763

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Fix typos found by codespell #5763

merged 2 commits into from
Jun 21, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 2, 2023

I have tried to leave out vendored 3rd party files, such as src/csync.

@mgallien
Copy link
Collaborator

@DimitriPapadopoulos thanks a lot
could you please rebase on the latest work in the master branch ?
I would like to see those changes be merged sooner rather than later

@DimitriPapadopoulos
Copy link
Contributor Author

@mgallien Rebased against master.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for all the fixes (especially those in the user documentation)
see my 2 comments

theme/colored/Nextcloud-macOS-icon.svg Outdated Show resolved Hide resolved
@mgallien
Copy link
Collaborator

@DimitriPapadopoulos absolutely no worries
the review is there to catch those kind of issues
by the way let me say it again, thanks a lot for your contribution
that is going to fix typos not only in the code but in the user documentation, that is really valuable

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #5763 (093b993) into master (bb393d3) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5763   +/-   ##
=======================================
  Coverage   60.40%   60.40%           
=======================================
  Files         145      145           
  Lines       18617    18617           
=======================================
+ Hits        11245    11246    +1     
+ Misses       7372     7371    -1     
Impacted Files Coverage Δ
src/common/filesystembase.cpp 76.43% <ø> (ø)
src/common/syncjournaldb.h 75.00% <ø> (ø)
src/common/syncjournalfilerecord.h 54.54% <ø> (ø)
src/common/utility.cpp 74.06% <ø> (ø)
src/common/utility.h 0.00% <ø> (ø)
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/accessmanager.cpp 88.88% <ø> (ø)
src/libsync/account.h 40.00% <ø> (ø)
src/libsync/bulkpropagatorjob.h 50.00% <ø> (ø)
src/libsync/capabilities.h 0.00% <ø> (ø)
... and 24 more

... and 1 file with indirect coverage changes

Signed-off-by: Dimitri Papadopoulos <[email protected]>
These change actual variable names.

Signed-off-by: Dimitri Papadopoulos <[email protected]>
@mgallien mgallien merged commit 61d7898 into nextcloud:master Jun 21, 2023
6 of 8 checks passed
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5763-fa96e0d31a647f4a61f7844ff70835de9527747d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch June 21, 2023 07:37
@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
@mgallien
Copy link
Collaborator

mgallien commented Jul 4, 2023

/backport to stable-3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants