Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for mass deployment. #5611

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Documentation for mass deployment. #5611

merged 1 commit into from
Jun 20, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

mgallien
mgallien requested changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
good for me but we miss the description of --overrideserverurl and --overridelocaldir
this is especially important because one can wonder what to use between --serverurl and --overrideserverurl

@allexzander
Copy link
Contributor Author

allexzander commented Apr 17, 2023 •
edited
Loading

thanks good for me but we miss the description of --overrideserverurl and --overridelocaldir this is especially important because one can wonder what to use between --serverurl and --overrideserverurl

fixed

mgallien
mgallien requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@allexzander allexzander force-pushed the feature/documentation-for-mass-deployment branch from 343d9e2 to cda7e08 Compare May 8, 2023 14:29
@allexzander allexzander requested a review from mgallien May 8, 2023 14:29
@allexzander
Copy link
Contributor Author

see my comment

fixed

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #5611 (cda7e08) into master (712f454) will decrease coverage by 1.12%.
The diff coverage is n/a.

❗ Current head cda7e08 differs from pull request most recent head ac7f563. Consider uploading reports for the commit ac7f563 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5611      +/-   ##
==========================================
- Coverage   60.36%   59.25%   -1.12%     
==========================================
  Files         143      143              
  Lines       18571    18450     -121     
==========================================
- Hits        11211    10933     -278     
- Misses       7360     7517     +157

see 39 files with indirect coverage changes

camilasan
camilasan requested changes May 16, 2023
View reviewed changes
doc/wizardaccountsetupcommandline.rst Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the feature/documentation-for-mass-deployment branch from cda7e08 to ac7f563 Compare June 20, 2023 09:17
@allexzander allexzander merged commit b2a2437 into master Jun 20, 2023
@allexzander allexzander deleted the feature/documentation-for-mass-deployment branch June 20, 2023 09:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5611-ac7f5632d16ee39d3a8fc4df155753463a67caeb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
@mgallien
Copy link
Collaborator

mgallien commented Jul 4, 2023

/backport to stable-3.9

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @camilasan