Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up systray.mm (macOS) #5602

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Clean up systray.mm (macOS) #5602

merged 5 commits into from
Jul 24, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Apr 13, 2023 •
edited
Loading

The code here lacks constness, proper indentation, and uses old property accessing methods in Obj-C -- this can be improved with some basic changes :)

@claucambra claucambra self-assigned this Apr 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #5602 (9c6e996) into master (a727971) will decrease coverage by 0.70%.
The diff coverage is n/a.

❗ Current head 9c6e996 differs from pull request most recent head 53cc438. Consider uploading reports for the commit 53cc438 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
- Coverage   60.08%   59.39%   -0.70%     
==========================================
  Files         145      143       -2     
  Lines       18762    18445     -317     
==========================================
- Hits        11274    10956     -318     
- Misses       7488     7489       +1

see 57 files with indirect coverage changes

allexzander
allexzander approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra Nice one. Just check 1 tiny comment.

src/gui/systray.mm Outdated Show resolved Hide resolved
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5602-53cc438bf1ecad4bd45b317c04313040783528bc-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 9727440 into master Jul 24, 2023
10 checks passed
@claucambra claucambra deleted the bugfix/clean-up-systray-mac branch July 24, 2023 23:47
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @allexzander @mgallien