-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disable talk chat notifications #5433
base: master
Are you sure you want to change the base?
Conversation
claucambra
commented
Feb 13, 2023
SonarCloud Quality Gate failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5433 +/- ##
==========================================
- Coverage 60.79% 57.93% -2.87%
==========================================
Files 145 141 -4
Lines 18836 18142 -694
==========================================
- Hits 11451 10510 -941
- Misses 7385 7632 +247
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you have a look at my comment, rebase and fix the conflict ?
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
b5a132c
to
cafe626
Compare
Thanks for review @mgallien addressed comments |
AppImage file: nextcloud-PR-5433-cafe626090cb5db74f4816c7c116b35ce16f25a3-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |