Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Still an issue password generation for shares, improve generator #5944

Closed
5 of 8 tasks
AndyXheli opened this issue Jul 31, 2023 · 0 comments · Fixed by #5966
Closed
5 of 8 tasks

[Bug]: Still an issue password generation for shares, improve generator #5944

AndyXheli opened this issue Jul 31, 2023 · 0 comments · Fixed by #5966

Comments

@AndyXheli
Copy link

AndyXheli commented Jul 31, 2023

⚠️ Before submitting, please verify the following: ⚠️

Bug description

Should of been fixed in #5908 but still an issue

Steps to reproduce

Noticed if Enforce password protection is checked the desktop client app will not generate a password.
Noticed if i have always ask for password is checked the desktop client will set a password but will not inform me and i have to go under the link share a remove the password or setup my own since its hidden.

Expected behavior

Should generate the password and allow the end user to copy it so they can share it =

Which files are affected by this bug

ALL

Operating system

Windows

Which version of the operating system you are running.

W11, W10

Package

Appimage

Nextcloud Server version

27.0.1

Nextcloud Desktop Client version

3.9.1

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 3.3.6 to 3.4.0)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

Error with Enforce password protection checked
{"reqId":"fLocmMt08tdzWPWWsBgQ","level":3,"time":"2023-07-31T12:32:50-05:00","remoteAddr":"10.8.0.5","user":"admin","app":"no app in context","method":"POST","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares?format=json","message":"Passwords are enforced for link and mail shares","userAgent":"Mozilla/5.0 (Windows) mirall/3.9.1stable-Win64 (build 20230725) (Nextcloud, windows-10.0.22621 ClientArchitecture: x86_64 OsArchitecture: x86_64)","version":"27.0.1.2","exception":{"Exception":"InvalidArgumentException","Message":"Passwords are enforced for link and mail shares","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/Share20/Manager.php","line":780,"function":"verifyPassword","class":"OC\\Share20\\Manager","type":"->"},{"file":"/var/www/nextcloud/apps/files_sharing/lib/Controller/ShareAPIController.php","line":834,"function":"createShare","class":"OC\\Share20\\Manager","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":230,"function":"createShare","class":"OCA\\Files_Sharing\\Controller\\ShareAPIController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":137,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":183,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/nextcloud/ocs/v1.php","line":64,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/nextcloud/ocs/v2.php","line":23,"args":["/var/www/nextcloud/ocs/v1.php"],"function":"require_once"}],"File":"/var/www/nextcloud/lib/private/Share20/Manager.php","Line":189,"CustomMessage":"--"},"id":"64c7f37992e5d"}

Additional info

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant