Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attention possible case sensitive clash - no conflict resolution provided #3277

Open
ferdiga opened this issue May 6, 2021 · 13 comments
Open
Labels
approved bug approved by the team enhancement enhancement of a already implemented feature/code feature: 🔄 sync engine hotspot: filename handling Filenames - invalid, portable, blacklisting, etc.

Comments

@ferdiga
Copy link

ferdiga commented May 6, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

clicking on the error message should open a meaningful message.
"meaningful" - as I do not understand the source of the error I can't say what is meaningful

Actual behaviour

the error message points to a directory - I do not see any case sensitive issues in the directory name.

Steps to reproduce

  1. automatic sync

Client configuration

Client version: Version 3.2.0 (macOS).

Operating system:
macOS 11.3.1
OS language:

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From Nextcloud or distro) (Linux only):

Installation path of client:

Server configuration

Nextcloud version:
20.0.9 on a Hetzner storage service
Storage backend (external storage):

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

  1. Client logfile:
    Since 3.1: Under the "General" settings, you can click on "Create Debug Archive ..." to pick the location of where the desktop client will export the logs and the database to a zip file.
    On previous releases: Via the command line: nextcloud --logdebug --logwindow or nextcloud --logdebug --logfile log.txt
    (See also https://docs.nextcloud.com/desktop/3.0/troubleshooting.html#log-files)

  2. Web server error log:

  3. Server logfile: nextcloud log (data/nextcloud.log):

@ferdiga ferdiga added the bug label May 6, 2021
@FlexW
Copy link

FlexW commented May 6, 2021

Could you provide us a screenshot from the error message or tell us what the error message said? Can you provide us any steps we can take to reproduce the exact same error message?

@ferdiga
Copy link
Author

ferdiga commented May 6, 2021

Meanwhile I upgraded the desktop client to 3.2.1
20210506 172628 Nextcloud Settings

@ferdiga
Copy link
Author

ferdiga commented May 6, 2021

I migrated from a ubuntu 20.04 to a Macbook

  • copied all files with rsync -av from the linux machine to the Macbook
  • installed nextcloud client and choose the copied directory as root for the sync - choosing to keep existing files
    this works fine except a few files producing an error

BTW I had this error already on linux machines doing the same

@allexzander
Copy link
Contributor

Hard to say how this can be improved. Maybe, pointing out the exact file name that is attempted to be copied and the file name of an already existing file that results in a clash. This will surely increase the length of the error message that doesn't fit nicely in the limited space of the UI it is displayed in.

Shouldn't the filename in the error message make a user gonna want to check that file on the server? It's a nice hint already.

Not sure myself. I've faced this issue when having two similarly named files having capital and the normal case of extensions (one is .PNG, while another is .png). While this works on Linux, this doesn't work on Windows. Looks like this doesn't work on mac OS too.

@allexzander allexzander added enhancement enhancement of a already implemented feature/code and removed bug labels May 7, 2021
@ferdiga
Copy link
Author

ferdiga commented May 7, 2021

Well, I mentioned - I copied the files from Linux to Mac using rsync - hence the filename should be literally the same. (except rsync changes file names)
The linux machine was synced to the NC using th NC desktop on Linux and synced again using NC desktop on MAC

The design of the error messages should be made more readable any way.
see also
#3276

@ferdiga
Copy link
Author

ferdiga commented May 20, 2021

Hi,
definitely an upper/lower case issue.
after renaming the file - sync works, it's just a painful experience to rename some 100 files

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale needs info issue with needs info and no answer label Jun 18, 2021
@ferdiga
Copy link
Author

ferdiga commented Jun 18, 2021

I fixed the problem manually,
what can I provide?

@FlexW
Copy link

FlexW commented Jun 21, 2021

@ferdiga Everything is fine. I guess we will improve the error message.

@FlexW FlexW added approved bug approved by the team and removed stale needs info issue with needs info and no answer labels Jun 21, 2021
@gege2b
Copy link

gege2b commented Apr 29, 2022

Hi
I just had the same problem between linux and windows clients
I renamed a bunch of files from MiXEdCase filename to lowercase filename on my linux box, the filenames basically didn't change except the case

And right now, my windows client show me a conflict error for each renamed files, and is uploading back the MiXedCase files, creating hundreds of duplicates on my linux client.

both clients are 3.4.4 (on windows 10 and mint 20)
Server is 23.0.4

@marbx
Copy link

marbx commented Sep 4, 2022

Similar to #4103

@maximelehericy
Copy link

So now a conflict resolution is provided see picture below.
image
however, the existing filename is empty, so it requires the user to search for the existing filename prior setting the new name.

@joshtrichards joshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Aug 16, 2024
@codeling
Copy link

codeling commented Sep 4, 2024

case clash conflict resolution still has an issue for me (client 3.13.3). the dialog shows a filename but clicking OK just leads to the dialog staying open and the OK button being grayed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug approved by the team enhancement enhancement of a already implemented feature/code feature: 🔄 sync engine hotspot: filename handling Filenames - invalid, portable, blacklisting, etc.
Projects
None yet
Development

No branches or pull requests

8 participants