From ccc72baae9b543a1e5fccc53f79ccbc6b3410d7f Mon Sep 17 00:00:00 2001 From: alex-z Date: Thu, 16 Nov 2023 10:56:12 +0100 Subject: [PATCH] Added some todos. Signed-off-by: alex-z --- src/libsync/owncloudpropagator.cpp | 2 ++ src/libsync/propagateremotemove.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libsync/owncloudpropagator.cpp b/src/libsync/owncloudpropagator.cpp index 5f1825aca833..acc613276b36 100644 --- a/src/libsync/owncloudpropagator.cpp +++ b/src/libsync/owncloudpropagator.cpp @@ -564,6 +564,8 @@ void OwncloudPropagator::start(SyncFileItemVector &&items) // when a folder is moved on the local device we only need to perform one MOVE on the server and then just update database, so we only keep unique moves (topmost moved folder items) cleanupLocallyMovedFoldersFromNestedItems(items); + //TODO: After cleanup, in case items size changes, we need to update the progress info (maybe in: void SyncEngine::slotDiscoveryFinished or move this code to slotDiscoveryFinished) + qCInfo(lcPropagator) << "END ITEMS CLEANUP"; for (const auto &item : items) { qCInfo(lcPropagator) << "item->_originalFile:" diff --git a/src/libsync/propagateremotemove.cpp b/src/libsync/propagateremotemove.cpp index a52f3f75e62f..b44da2e541c0 100644 --- a/src/libsync/propagateremotemove.cpp +++ b/src/libsync/propagateremotemove.cpp @@ -318,7 +318,7 @@ void PropagateRemoteMove::finalize() // the following slow code is only useful for VFS with suffix which is used for TestSyncVirtualFiles::testPinStateLocals test case // TODO: Get rid of the TestSyncVirtualFiles::testPinStateLocals or change it, native Virtual Files (e.g. CfAPI do not need this code as pinstate is moved with corresponding placeholder) if (!propagator()->_journal->getFilesBelowPath(_item->_renameTarget.toUtf8(), [&](const SyncJournalFileRecord &rec) { - // not sure if this is needed, inode seems to never change for move/rename + // TODO: not sure if this is needed, inode seems to never change for move/rename auto newItem = SyncFileItem::fromSyncJournalFileRecord(rec); newItem->_originalFile = QString(newItem->_file).replace(_item->_renameTarget, origin); newItem->_renameTarget = newItem->_file;