Improve card title editing #6327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
There was a problem hiding this comment.
The inlineEditingBlocked computed doesn't seem to be used anymore.
|
It works well. BTW, I think we should autofocus the card title when user select menu "Edit title". Currently, after selecting "Edit title", user has to click on card title to edit it. |
|
Yes, that is the main issue I'm still struggling with :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a couple of usability issues with the inline card title editing, by making it disabled by default. We add a new edit title menu entry, but otherwise just open the card on click.
Additionally this allows marking text on deck cards and is rendering clickable links.