Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Option to Retrieve All Labels from a Specified Board #5325

Closed
wants to merge 5 commits into from

Conversation

erseco
Copy link

@erseco erseco commented Nov 24, 2023

Hello Nextcloud Deck Team,

I am submitting this pull request to introduce a new small feature to the Deck API. This feature allows users to retrieve all labels from a specified board.

Feature Description

Currently, the Deck API does not provide a direct way to fetch all labels associated with a specific board. This feature aims to fill this gap by adding an endpoint that enables users to easily access all labels of a board. This enhancement will be beneficial for users who need to manage labels programmatically or integrate Deck with other tools.

Implementation Details

  • A new endpoint has been added: GET /boards/{boardId}/labels.
  • This endpoint returns a list of all labels associated with the board specified by boardId.

Testing

  • Manual testing has been performed to ensure the feature works as expected in different scenarios.

I believe this feature will significantly enhance the flexibility and usability of the Deck API. I look forward to your feedback and any suggestions for improvement.

Thank you for considering this contribution.

Best regards,
Ernesto

Add option to API to get al labels from a specified board

Signed-off-by: Ernesto Serrano <[email protected]>
}
$since = $date->getTimestamp();
}
$label = $this->labelService->findAll($this->request->getParam('boardId'), $since);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you tested but there is no findAll method on the label service, so this won't work in its current state.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Please check the inline comments.

erseco and others added 2 commits December 10, 2023 21:07
Co-authored-by: Julius Härtl <[email protected]>
Signed-off-by: Ernesto Serrano <[email protected]>
@erseco
Copy link
Author

erseco commented Dec 10, 2023

Not really needed this feature because the labels of the board are retrieved with the board, I'm just closing this PR. Sorry for the inconvenience.

@erseco erseco closed this Dec 10, 2023
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants