-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Option to Retrieve All Labels from a Specified Board #5325
Conversation
Add option to API to get al labels from a specified board Signed-off-by: Ernesto Serrano <[email protected]>
Fix import Signed-off-by: Ernesto Serrano <[email protected]>
} | ||
$since = $date->getTimestamp(); | ||
} | ||
$label = $this->labelService->findAll($this->request->getParam('boardId'), $since); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how you tested but there is no findAll method on the label service, so this won't work in its current state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please check the inline comments.
Co-authored-by: Julius Härtl <[email protected]> Signed-off-by: Ernesto Serrano <[email protected]>
update from upstream
Not really needed this feature because the labels of the board are retrieved with the board, I'm just closing this PR. Sorry for the inconvenience. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Hello Nextcloud Deck Team,
I am submitting this pull request to introduce a new small feature to the Deck API. This feature allows users to retrieve all labels from a specified board.
Feature Description
Currently, the Deck API does not provide a direct way to fetch all labels associated with a specific board. This feature aims to fill this gap by adding an endpoint that enables users to easily access all labels of a board. This enhancement will be beneficial for users who need to manage labels programmatically or integrate Deck with other tools.
Implementation Details
GET /boards/{boardId}/labels
.boardId
.Testing
I believe this feature will significantly enhance the flexibility and usability of the Deck API. I look forward to your feedback and any suggestions for improvement.
Thank you for considering this contribution.
Best regards,
Ernesto