-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scroll board by dragging #5293
scroll board by dragging #5293
Conversation
Cypress is green, so i'm marking this as ready for review. |
9c22a68
to
2ff47e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shoetten. Thanks a lot for your contribution, this is very much appreciated.
I just left some small comments inline, otherwise this is a great change, happy to merge once clarified. Having the code within the Board component is totally fine with me.
Signed-off-by: Simon Hötten <[email protected]>
2ff47e3
to
d17498b
Compare
Thanks for the quick adjustment 🥳 |
Thanks for the fast review 🎉 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Motivated by the recent uptake of activity in this repo i decided to finally tackle this issue. The PR adds horizontal scrolling of boards by dragging without adding another dependency.
If you wan't the logic out of the board component, i can refactor. I felt like the change was small enough to keep it in there, but feel free to criticize ;)
TODO
Checklist