feat: Move to contenteditable for inline title editing #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Nov 13, 2023
•
juliusknorr
commented
- feat: Move to contenteditable for inline title editing
- fix Don't open input field when clicking on title in Deck #2563
- fix autosave card title #4522
juliusknorr
force-pushed
the
bugfix/multiple
branch
from
2ce1c4b
to
29d5913
Compare
juliusknorr
force-pushed
the
feat/inline-edit-new
branch
from
c7e3a12
to
8d43254
Compare
|
@juliushaertl I guess this PR is not done yet, right? As far as I can see, clicking the title is enabling title editing and opening card detail at the same time. |
|
Will check maybe I messed something up by splitting the commits out |
fix #2563 fix #4522 Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
feat/inline-edit-new
branch
from
8d43254
to
a6b561a
Compare
|
Fixed, apparently I did miss that as when using the sidebar it is not that disturbing compared to the modal. |
luka-nextcloud
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.