Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bidi text #5258

Merged
merged 2 commits into from
Nov 6, 2023
Merged

add support for bidi text #5258

merged 2 commits into from
Nov 6, 2023

Conversation

jamazi
Copy link
Contributor

@jamazi jamazi commented Nov 5, 2023

fix #1959

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. Looks good 👍

@jamazi
Copy link
Contributor Author

jamazi commented Nov 6, 2023

cypress failed because this change made the text have extra white space:
https://vscode.dev/github/jamazi/deck/blob/main/src/components/Controls.vue#L27

Should I change the test file to trim white space or remove new line after h2 tag which will cause warning from the linter ?

@juliushaertl
Copy link
Member

Trimming in the tests sounds good to me 👍

@juliushaertl juliushaertl merged commit 078495f into nextcloud:main Nov 6, 2023
13 checks passed
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for bi-directional text
2 participants