NC29 Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter

[kaikli]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Describe the bug
Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /srv/http/nextcloud/apps/deck/lib/Service/ConfigService.php#234

Deck Version: 1.13.0

Operating system:

Web server: Apache/2.4.59
Database: 11.3.2-MariaDB
PHP version: PHP 8.3.7 (cli)
Nextcloud version: 29.0.1
Where did you install Nextcloud from: nextcloud.com

Logs

Nextcloud log (data/nextcloud.log)

{"reqId":"s7B2RXPDbz7Ao6cThje9","level":3,"time":"2024-05-27T06:14:33+00:00","remoteAddr":"192.168.188.42","user":"admin-czpDq1","app":"PHP","method":"GET","url":"/","message":"Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /srv/http/nextcloud/apps/deck/lib/Service/ConfigService.php#234","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0","version":"29.0.1.1","data":{"app":"PHP"}}

Browser log

Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /srv/http/nextcloud/apps/deck/lib/Service/ConfigService.php#234

[red-kite]

Same Error on every cron run (or manually triggered with any occ command):
PHP Deprecated: Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter in [...]/apps/deck/lib/Service/ConfigService.php on line 234
Nextcloud version: 29.0.1 (Deck 1.13.0)
PHP version: 8.2.19

[PatrickJosh]

See #5793, #5823, #5888. It has been fixed, but no release has been made since.

[Daniel-MFG]

Same error here...
Do they ever plan on doing a release with this fix in there?
(i already asked about this weeks ago...)

[linuxsquad]

After the latest update, seeing the same error

PHP Version: 8.2.4 Memory limit: 512 MB Max execution time: 3600 Upload max size: 2 GB OPcache Revalidate Frequency: 60 Extensions: Core, date, libxml, openssl, pcre, hash, json, random, Reflection, SPL, session, standard, cgi-fcgi, mysqlnd, apcu, bcmath, bz2, ctype, curl, dom, mbstring, fileinfo, filter, gd, gmp, iconv, imagick, intl, exif, PDO, zlib, posix, SimpleXML, sysvsem, xml, xmlwriter, zip, Phar, memcached, pdo_mysql, redis, xmlreader, Zend OPcache

Type: mysql Version: 10.6.12

[ibahnasy]

Still getting the same error on 29.0.2.

[joshtrichards]

Duplicate of #5793

The fix is merged (#5794) but we need to roll a new release with it still. I'll see what I can do to nudge that forward.

Manual patching of that PR is an option in the meantime for those so motivated.

[joshtrichards]

Please stop spam posting "same issue". It's a known issue. :-) If you need to express your experience, just thumbs up 👍 the original message: #5938 (comment)

[mleimbach-beeclever]

what/when are the usual release cycles ?
prev releases:
feb-> mar -> apr -> ?
it's end of june so it does not seem to be a set release cycle, right ?

what prevents a release of the bugfix if one is present and working?

[jessebot]

@mleimbach-beeclever I think it's just that @juliushaertl has been busy, but perhaps they notice this tag.

Julius, can you please help with a new release here? Even a beta release would let others easily test it as manually patching is kind of tedious, as for the nextcloud fpm-alpine docker image, patch is not installed by default. Otherwise, these errors fill up the logs.

[RainerEmrich]

@juliushaertl This is now fixed in 1.13.1, but unfortunately newly introduced in 1.12.3 for NC28.
I can open a new Bug report if required.

[rosa2]

I confirm that in version 1.12.3 for NC28 it was reintroduced.
Thanks for the app :)

[Daniel-MFG]

For me on NC29.0.3 the Deck update to 1.13.1 fixed the issue!
(finally we got clean logs again T-T)

@RainerEmrich
Thanks for this info! Helped me a lot.

[juliushaertl]

I confirm that in version 1.12.3 for NC28 it was reintroduced.
Thanks for the app :)

Thanks for letting me know. I just triggered backports of this for 27 and 28 as well. The issue was there quite long already, just PHP started to log those as errors with newer versions.

[kevin4463-godaddy]

NC 29.0.3
Deck 1.13.1
I was still getting the logs so I ended up modding the ConfigService.php at line 234 to the following

<?php //... public function setAttachementFolder(?string $userId, ?string $path): void { ... if ($path === null) { throw new BadRequestException('Path parameter is required but was not supplied'); } ... } php>

[r0gueone]

Since updating Deck to version 1.12.3 on NC version 28.0.7, my log is flooded with these errors. I'm not clear on what needs modified in the ConfigService.php file however - can anyone provide clarification on what I would need to do? Or, is there a new patch/fix coming to update to?

[joshtrichards]

I just triggered backports of this for 27 and 28 as well.

@juliushaertl (Cc: @grnd-alt): We still need to publish a new release with this backport for v28. The v28 published release doesn't have the backport in place, since it was built before the backport was merged.

@r0gueone - https://github.com/nextcloud/deck/pull/6045/files

[fmikker]

PHP: 8.1.29
NC: 27.1.11
Deck: 1.11.5

Any chance this will be backported to NC 27?