Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Toolbar wrap at different positions / unused space around editor #4686

Closed
reox opened this issue May 16, 2023 · 3 comments
Closed

Editor Toolbar wrap at different positions / unused space around editor #4686

reox opened this issue May 16, 2023 · 3 comments

Comments

@reox
Copy link
Contributor

reox commented May 16, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

The new text editor is very nice. However, I noticed that the toolbar sometimes wraps at different positions in the modal dialog.
In the sidebar, it is not visible, because the width of the editor is much smaller.

For example, sometimes almost all icons are visible, while at some instances, only three to four icons show up.
I'm not sure if this is an issue of deck or if it relates to github.com/nextcloud/text

There is also a lot of unused space for the editor (see screenshots)

Describe the solution you'd like
The whole toolbar should be visible, if space allows it.

Describe alternatives you've considered

Additional context

Only some icons show up:
grafik

Even less icons show up:
grafik

Most of the icons show up, but there is a lot of unused space on both sides (red arrows):
grafik

@reox
Copy link
Contributor Author

reox commented Jan 10, 2024

It looks like part of this issue were already resolved in NC 28 / Deck 1.12., i.e., the menu seems to be stable now and does not hide symbols anymore.

However, I think there is still too much unused space around the editor. Is that on purpose?

@juliushaertl
Copy link
Member

Yes, the maximum width is determined by the editor itself to accommodate a recommended reading width.

Will close this here as there is an upstream discussion in nextcloud/text#4024

@juliushaertl juliushaertl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@reox
Copy link
Contributor Author

reox commented Jan 12, 2024

Ah okay, did not know that this is on purpose, but it makes sense! Thanks for the information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants