Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update app store build and publish workflow #4049

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 23, 2024

Our release action is currently broken: https://github.com/nextcloud-releases/contacts/actions/runs/10061403925/job/27813430198

The problem seems to be NODE_ENV=production which causes some dev dependencies to not be installed.

@st3iny st3iny added the 3. to review Waiting for reviews label Jul 23, 2024
@st3iny st3iny requested a review from hamza221 July 23, 2024 15:53
@st3iny st3iny self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@28140c0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4049   +/-   ##
=======================================
  Coverage        ?   65.90%           
  Complexity      ?      261           
=======================================
  Files           ?       24           
  Lines           ?      786           
  Branches        ?        0           
=======================================
  Hits            ?      518           
  Misses          ?      268           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221 hamza221 merged commit ff1e2a3 into main Jul 23, 2024
26 checks passed
@hamza221 hamza221 deleted the ci/update-publish-workflow branch July 23, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants