Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contacts): starred group #3471

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(contacts): starred group #3471

wants to merge 2 commits into from

Conversation

avinash-0007
Copy link

@avinash-0007 avinash-0007 commented Jun 21, 2023 •
edited by ChristophWurst
Loading

This PR give the functionality of starring contact
Fixes #3469

nextcloud-bot and others added 2 commits June 21, 2023 16:47
@nextcloud-bot
Fix(l10n): Update translations from Transifex
f0d4817 
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Avinash Gusain <[email protected]>
starred group
066e16b 
Signed-off-by: Avinash Gusain <[email protected]>
@avinash-0007 avinash-0007 changed the title starred group draft: starred group Jun 26, 2023
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -1.82 ⚠️

Comparison is base (74d3185) 1.81% compared to head (0991b5d) 0.00%.

❗ Current head 0991b5d differs from pull request most recent head 066e16b. Consider uploading reports for the commit 066e16b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##              main   #3471      +/-   ##
==========================================
- Coverage     1.81%   0.00%   -1.82%     
  Complexity     272     272              
==========================================
  Files          113      25      -88     
  Lines         6126     826    -5300     
  Branches      1479       0    -1479     
==========================================
- Hits           111       0     -111     
+ Misses        5899     826    -5073     
+ Partials       116       0     -116

see 88 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst marked this pull request as draft June 26, 2023 17:00
@ChristophWurst ChristophWurst changed the title draft: starred group feat(contacts): starred group Jun 26, 2023
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 will be requested when the pull request is marked ready for review hamza221 is a code owner

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov will be requested when the pull request is marked ready for review GVodyanov is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starring contacts
4 participants
@avinash-0007 @ChristophWurst @szaimen @nextcloud-bot