Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only page content sometimes outdated #1437

Closed
juliusknorr opened this issue Aug 22, 2024 · 5 comments · Fixed by #1450
Closed

Read only page content sometimes outdated #1437

juliusknorr opened this issue Aug 22, 2024 · 5 comments · Fixed by #1450
Assignees
Labels
bug: regression bug Something isn't working

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Aug 22, 2024

We have seen some reports that the read only rendering of a page is sometimes outdated. There are no clear steps to reproduce this yet, though a few interesting aspects:

  • Reloading the page does still show the old content
  • Switching back to edit mode has the new content in place
  • Using a different browser also shows the new content in read only mode

There is a video of it shared by Fabrice in our chat

@juliusknorr
Copy link
Member Author

Sometimes there seems to be a cached webdav GET in firefox but reports were around Chrome and I haven't managed to see that locally

image

@juliusknorr juliusknorr added the bug Something isn't working label Aug 22, 2024
@juliusknorr
Copy link
Member Author

I managed to reproduce this again on our company instance, also checking and even after a reload the Readme.md request was cached.

@mejo- Could you please check that? Maybe we just need a cachebuster on the webdav URL to make sure it is always updated if the content changed

@juliusknorr
Copy link
Member Author

Steps taken so far to reproduce this for me:

  • Browser caching enabled
  • Edit a page, paste something into it
  • Switch to another page relatively quick
  • Switch back to the originally edited page

@mejo-
Copy link
Member

mejo- commented Aug 28, 2024

Debugging revealed two things:

  1. Collectives doesn't update the reader content with the editor content at initial load. fix(editorApi): Add support for a onCreate callback that gets content text#6274 will help with that.
  2. The DAV request that is supposed to fetch the file content doesn't go out on Firefox, probably because it thinks that it already has it cached. This is not reproducible on Chromium, so I suspect a bug in Firefox cache handling.

In any case, adding a cache buster parameter to the DAV request seems sensible, as we always want to get the latest DAV content and don't want anybody to cache this for us.

@mejo-
Copy link
Member

mejo- commented Aug 28, 2024

@juliushaertl I also checked if reverting nextcloud/server#46320 changes anything here, it does not.

mejo- added a commit that referenced this issue Aug 28, 2024
Enures that we always get the latest DAV content and nobody (neither
browser nor server) cache anything in between.

Fixes: #1437

Signed-off-by: Jonas <[email protected]>
mejo- added a commit that referenced this issue Aug 28, 2024
Enures that we always get the latest DAV content and nobody (neither
browser nor server) cache anything in between.

Fixes: #1437

Signed-off-by: Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: regression bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants