Switch to synchronous workflow #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimishavijay
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Nice! Great that this is possible! :)
How about some small icon and wording changes?
- "Your task is running" --> "Getting results..."
- "If it takes too long..." --> The input (example "what is 2+2?") (ellipsize after 2 lines)
- Remove icon for "Run in background" button (it seems a bit too close to a cancel operation button)
- Scheduled modal: "Your task has been scheduled. You will receive a notification when it has finished" --> "Your task has been scheduled"
- Subline: "You will receive a notification when it has finished"
- Use a tertiary button for close button
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
|
@nimishavijay Thanks for the feedback! All done: vokoscreenNG-2023-11-16_11-53-55.mp4 |
This was referenced Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @jancborchardt, here is the synchronous workflow:
We always immediately run the task and wait for the result, showing a spinner in the UI. If users are bored to wait, they can click the schedule button which will stop the sync request and schedule the task just like before.
Sync:
vokoscreenNG-2023-11-15_15-35-46.mp4
Bored:
vokoscreenNG-2023-11-15_15-39-55.mp4