From d98f014ab2f50b25a4db3fb95e362d4ed552b657 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Thu, 25 Jul 2024 12:26:10 +0200
Subject: [PATCH] fix form validation for enums, fix style for enums, set sort
 order for the new translate task type

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 lib/Service/AssistantService.php               |  3 ++-
 src/components/AssistantTextProcessingForm.vue |  2 +-
 src/components/fields/EnumField.vue            | 10 +++++-----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/lib/Service/AssistantService.php b/lib/Service/AssistantService.php
index a366a2df..0d0b8cc6 100644
--- a/lib/Service/AssistantService.php
+++ b/lib/Service/AssistantService.php
@@ -36,6 +36,7 @@
 use OCP\TaskProcessing\TaskTypes\TextToTextHeadline;
 use OCP\TaskProcessing\TaskTypes\TextToTextSummary;
 use OCP\TaskProcessing\TaskTypes\TextToTextTopics;
+use OCP\TaskProcessing\TaskTypes\TextToTextTranslate;
 use Parsedown;
 use PhpOffice\PhpWord\IOFactory;
 use Psr\Log\LoggerInterface;
@@ -56,7 +57,7 @@ class AssistantService {
 		'context_chat:context_chat' => 3,
 		'legacy:TextProcessing:OCA\ContextChat\TextProcessing\ContextChatTaskType' => 3,
 		AudioToText::ID => 4,
-		// TODO translate: 5 (translate is not migrated to taskProcessing yet)
+		TextToTextTranslate::ID => 5,
 		ContextWrite::ID => 6,
 		TextToImage::ID => 7,
 		TextToTextSummary::ID => 8,
diff --git a/src/components/AssistantTextProcessingForm.vue b/src/components/AssistantTextProcessingForm.vue
index 8f67ef81..5dbd55ca 100644
--- a/src/components/AssistantTextProcessingForm.vue
+++ b/src/components/AssistantTextProcessingForm.vue
@@ -281,7 +281,7 @@ export default {
 				}
 				const fieldType = taskType.inputShape[k].type
 				const value = this.myInputs[k]
-				return (fieldType === SHAPE_TYPE_NAMES.Text && typeof value === 'string' && !!value?.trim())
+				return ([SHAPE_TYPE_NAMES.Text, SHAPE_TYPE_NAMES.Enum].includes(fieldType) && typeof value === 'string' && !!value?.trim())
 					|| ([
 						SHAPE_TYPE_NAMES.Number,
 						SHAPE_TYPE_NAMES.File,
diff --git a/src/components/fields/EnumField.vue b/src/components/fields/EnumField.vue
index e5e47d49..4bc76365 100644
--- a/src/components/fields/EnumField.vue
+++ b/src/components/fields/EnumField.vue
@@ -1,11 +1,11 @@
 <template>
-	<div class="number-field">
+	<div class="enum-field">
 		<label :for="'input-' + fieldKey">
 			{{ field.description }}
 		</label>
 		<NcSelect
 			:id="'input-' + fieldKey"
-			class="enum-field"
+			class="enum-field-input"
 			:value="selectValue"
 			:options="options"
 			:clearable="true"
@@ -84,13 +84,13 @@ export default {
 </script>
 
 <style lang="scss">
-.number-field {
+.enum-field {
 	display: flex;
 	flex-direction: column;
 	align-items: start;
 
-	.number-input-field {
-		width: 300px !important;
+	&-input {
+		min-width: 300px !important;
 		margin-top: 0 !important;
 	}
 }